Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 4629042: code review 4629042: gc: work around goto bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by rsc
Modified:
12 years, 9 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: work around goto bug

Patch Set 1 #

Patch Set 2 : diff -r 6c9c33c799f1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 655a4be3968f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -0 lines) Patch
M src/cmd/5g/gsubr.c View 1 1 chunk +58 lines, -0 lines 0 comments Download
M src/cmd/6g/gsubr.c View 1 1 chunk +35 lines, -0 lines 0 comments Download
M src/cmd/8g/gsubr.c View 1 1 chunk +35 lines, -0 lines 0 comments Download
M src/cmd/gc/dcl.c View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/cmd/gc/gen.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/go.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
A test/fixedbugs/bug344.go View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2011-06-16 04:18:42 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=ec3b60d1fe6e *** gc: work around goto bug R=ken2 CC=golang-dev http://codereview.appspot.com/4629042
12 years, 9 months ago (2011-06-16 04:18:46 UTC) #2
ken3
12 years, 9 months ago (2011-06-16 11:19:20 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b