Issue 4628073: code review 4628073: exp/template: boolean constants

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4628073: code review 4628073: exp/template: boolean constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by r

Modified:
13 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

exp/template: boolean constants

Patch Set 1 #

Patch Set 2 : diff -r b3e7f469a443 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -9 lines)			Patch
M	src/pkg/exp/template/exec.go	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	src/pkg/exp/template/exec_test.go	View	6 chunks	+11 lines, -8 lines	0 comments	Download
M	src/pkg/exp/template/lex.go	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/pkg/exp/template/lex_test.go	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/exp/template/parse.go	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	src/pkg/exp/template/parse_test.go	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-06-29 04:52:24 UTC) #1

13 years, 10 months ago (2011-06-29 05:02:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=fa2d4e363b02 ***

exp/template: boolean constants

R=rsc
CC=golang-dev
http://codereview.appspot.com/4628073

Expand All Messages | Collapse All Messages