Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13856)

Issue 4627062: Replace Tab with 8 Spaces for .py files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by pkx166h
Modified:
12 years, 10 months ago
Reviewers:
Keith, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Replace Tab with 8 Spaces for .py files As per GOP Prop 1 - Python formatting. All files in /python/ and /scripts/ were checked.

Patch Set 1 #

Patch Set 2 : Second attempt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+955 lines, -955 lines) Patch
M python/convertrules.py View 1 75 chunks +691 lines, -691 lines 0 comments Download
M python/fontextract.py View 1 3 chunks +50 lines, -50 lines 0 comments Download
M python/lilylib.py View 1 7 chunks +50 lines, -50 lines 0 comments Download
M python/musicxml.py View 1 24 chunks +162 lines, -162 lines 0 comments Download
M python/rational.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Keith
The bad news is, you replaced tabs by 4 columns when we needed 8 column. ...
12 years, 10 months ago (2011-06-24 02:52:04 UTC) #1
pkx166h
Second go. Thanks Keith.
12 years, 10 months ago (2011-06-24 03:14:50 UTC) #2
Carl
LGTM
12 years, 10 months ago (2011-06-24 04:37:47 UTC) #3
pkx166h
12 years, 10 months ago (2011-06-24 11:58:28 UTC) #4
Thanks Keith and Carl.

Pushed as

20596e17d6f8026f7199c9ae0e5f03517631a66c

Closing this issue
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b