Issue 4627057: [google] fix kernel fdo booting issue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4627057: [google] fix kernel fdo booting issue

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by xur

Modified:
13 years, 9 months ago

Reviewers:
davidxl, Sharad Singhai

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	gcc/libgcov.c	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

xur

This change removes the define of TARGET_VTABLE_USES_DESCRIPTORS in kernel fdo which causes kernel panic in ...

13 years, 9 months ago (2011-06-23 06:22:52 UTC) #1

Sharad Singhai

13 years, 9 months ago (2011-06-23 06:36:29 UTC) #2

Okay for google/main.

Sharad

On Wed, Jun 22, 2011 at 11:22 PM, Rong Xu <xur@google.com> wrote:
>
> This change removes the define of TARGET_VTABLE_USES_DESCRIPTORS in
> kernel fdo which causes kernel panic in indirect-call-profiling.
>
> Tested with 2.6.34 kernel. This change only affects kernel code.
>
> This is for google_main only.
>
> -Rong
>
> 2011-06-22   Rong Xu  <xur@google.com>
>
>        * gcc/libgcov.c: (TARGET_VTABLE_USES_DESCRIPTORS): Remove.
>
> Index: gcc/libgcov.c
> ===================================================================
> --- gcc/libgcov.c       (revision 175328)
> +++ gcc/libgcov.c       (working copy)
> @@ -36,7 +36,6 @@
>  # define L_gcov_average_profiler
>  # define L_gcov_ior_profiler
>
> -# define TARGET_VTABLE_USES_DESCRIPTORS 0
>  # define HAVE_CC_TLS 0
>  # define __GCOV_KERNEL__
>
>
> --
> This patch is available for review at http://codereview.appspot.com/4627057

Expand All Messages | Collapse All Messages