Issue 4627047: code review 4627047: goinstall: always rebuild a package after its dependenc...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4627047: code review 4627047: goinstall: always rebuild a package after its dependenc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by adg

Modified:
13 years, 11 months ago

Reviewers:
rsc

CC:
golang-dev, r

Visibility:
Public.

Description

goinstall: always rebuild a package after its dependencies are built

Patch Set 1 #

Patch Set 2 : diff -r 61ed63d57306 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	src/cmd/goinstall/main.go	View		3 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-06-18 10:04:18 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=1ad616fb313d *** goinstall: always rebuild a package after its dependencies are built ...

13 years, 11 months ago (2011-06-18 23:36:57 UTC) #3

rsc

Wait, why? If script.Stale doesn't think it needs rebuilding, why does it need rebuilding? It ...

13 years, 11 months ago (2011-06-20 15:40:13 UTC) #4

adg

13 years, 11 months ago (2011-06-20 22:53:16 UTC) #5

On 21 June 2011 01:40, Russ Cox <rsc@golang.org> wrote:
> Wait, why?
>
> If script.Stale doesn't think it needs rebuilding,
> why does it need rebuilding?
>
> It sounds like the script doesn't include all the
> information about inputs that it should.

You're right, there's a better fix. I will investigate today.

Andrew

Expand All Messages | Collapse All Messages