Issue 4626065: code review 4626065: re2: do not edit Regexp during IsAnchorStart, IsAnchorEnd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4626065: code review 4626065: re2: do not edit Regexp during IsAnchorStart, IsAnchorEnd (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by rsc

Modified:
12 years, 10 months ago

Reviewers:

CC:
r, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2: do not edit Regexp during IsAnchorStart, IsAnchorEnd Must never edit existing regexps: they are logically immutable. Was causing RE2::Regexp to give back the wrong answer.

Patch Set 2 : diff -r b33ecb9b4ee7 https://re2.googlecode.com/hg/ #

Patch Set 3 : diff -r b33ecb9b4ee7 https://re2.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r b33ecb9b4ee7 https://re2.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -48 lines)			Patch
	M	re2/compile.cc	View	1 2 3	2 chunks	+80 lines, -42 lines	0 comments	Download
	M	re2/testing/re2_test.cc	View	1	4 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg/

12 years, 10 months ago (2011-06-21 22:10:19 UTC) #1

LGTM http://codereview.appspot.com/4626065/diff/4001/re2/compile.cc File re2/compile.cc (right): http://codereview.appspot.com/4626065/diff/4001/re2/compile.cc#newcode860 re2/compile.cc:860: if (re == NULL || depth >= 4) ...

12 years, 10 months ago (2011-06-21 22:16:17 UTC) #2

rsc

12 years, 10 months ago (2011-06-22 01:45:59 UTC) #3

*** Submitted as http://code.google.com/p/re2/source/detail?r=f6d25e6f2ce1 ***

re2: do not edit Regexp during IsAnchorStart, IsAnchorEnd

Must never edit existing regexps: they are logically immutable.
Was causing RE2::Regexp to give back the wrong answer.

R=r
CC=re2-dev
http://codereview.appspot.com/4626065

Expand All Messages | Collapse All Messages