Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 4626041: code review 4626041: syscall: add LSF support for linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by mikio
Modified:
13 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

syscall: add LSF support for linux

Patch Set 1 : diff -r dd3913e4b4b9 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 4d789ab9a41d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4d789ab9a41d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -1 line) Patch
M src/pkg/syscall/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A src/pkg/syscall/lsf_linux.go View 1 1 chunk +78 lines, -0 lines 0 comments Download
M src/pkg/syscall/mkerrors.sh View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/syscall/types_linux.c View 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_386.go View 2 chunks +102 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_amd64.go View 2 chunks +102 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_arm.go View 3 chunks +105 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_386.go View 2 chunks +15 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_amd64.go View 2 chunks +15 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_arm.go View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2011-06-16 11:34:07 UTC) #1
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2011-06-17 02:57:00 UTC) #2
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 10 months ago (2011-06-19 15:17:19 UTC) #3
rsc
LGTM If it's the Linux Socket Filter why do the #define names begin with BPF_?
13 years, 10 months ago (2011-06-20 18:51:22 UTC) #4
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=209da6914cd6 *** syscall: add LSF support for linux R=rsc CC=golang-dev http://codereview.appspot.com/4626041 Committer: ...
13 years, 10 months ago (2011-06-20 18:51:35 UTC) #5
mikio
13 years, 10 months ago (2011-06-20 22:19:56 UTC) #6
On Tue, Jun 21, 2011 at 3:51 AM,  <rsc@golang.org> wrote:

> LGTM

Thanks.

> If it's the Linux Socket Filter why do the #define names begin with
> BPF_?

Probably it's a historical reason. At first just imported bpf.h, at some
point somebody improved filter applying/withdrawal framework except
BFP programming stuff.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b