code review 4625078: misc/vim: allow only utf-8 for fileencoding.

misc/vim: allow only utf-8 for fileencoding.

[mattn, 2011-06-30 06:07:07]

Hello golang-dev@googlecode.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
http://go.googlecode.com/hg/

[dsymonds, 2011-06-30 06:14:15]

http://codereview.appspot.com/4625078/diff/5001/misc/vim/ftdetect/gofiletype.vim
File misc/vim/ftdetect/gofiletype.vim (right):

http://codereview.appspot.com/4625078/diff/5001/misc/vim/ftdetect/gofiletype....
misc/vim/ftdetect/gofiletype.vim:1: au BufReadPre *.go set fileencodings=utf-8
I don't think it needs to be *Pre.

Just collapse the two lines to
  au BufRead,BufNewFile *.go set filetype=go fileencodings=utf-8

[mattn, 2011-06-30 06:17:01]

http://codereview.appspot.com/4625078/diff/5001/misc/vim/ftdetect/gofiletype.vim
File misc/vim/ftdetect/gofiletype.vim (right):

http://codereview.appspot.com/4625078/diff/5001/misc/vim/ftdetect/gofiletype....
misc/vim/ftdetect/gofiletype.vim:1: au BufReadPre *.go set fileencodings=utf-8
On 2011/06/30 06:14:15, dsymonds wrote:
> I don't think it needs to be *Pre.
> 
> Just collapse the two lines to
>   au BufRead,BufNewFile *.go set filetype=go fileencodings=utf-8

Done.

[dsymonds, 2011-06-30 06:18:42]

http://codereview.appspot.com/4625078/diff/1002/misc/vim/ftdetect/gofiletype.vim
File misc/vim/ftdetect/gofiletype.vim (right):

http://codereview.appspot.com/4625078/diff/1002/misc/vim/ftdetect/gofiletype....
misc/vim/ftdetect/gofiletype.vim:1: au BufReadPre *.go set fileencodings=utf-8
uh, this line isn't needed at all

[mattn, 2011-06-30 06:18:58]

Hello golang-dev@googlecode.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2011-06-30 06:19:20]

LGTM

[dsymonds, 2011-06-30 06:20:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=c051dc36c416 ***

misc/vim: allow only utf-8 for fileencoding.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4625078

Committer: David Symonds <dsymonds@golang.org>

[mattn, 2011-06-30 06:22:46]

Hmm, this don't work with

set encoding=cp932
set fileencodings=utf-8,cp932

then

:e foo.go

but 

:e ++enc=utf-8 foo.go

is working. it shouldn't use BufRead. probably it should use BufReadPre.

On 2011/06/30 06:20:04, dsymonds wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=c051dc36c416 ***
> 
> misc/vim: allow only utf-8 for fileencoding.
> 
> R=golang-dev, dsymonds
> CC=golang-dev
> http://codereview.appspot.com/4625078
> 
> Committer: David Symonds <mailto:dsymonds@golang.org>

[dsymonds, 2011-06-30 06:26:51]

D'oh.

What about just changing BufRead to BufReadPre?

[mattn, 2011-06-30 06:35:56]

BufRead occur after the reading file.
BufRaedPre is before.

And fileencoding option modify state of "file changed".
Then it should be "go file arrow ONLY utf-8 for reading."

And more, when make new go buffer, this should be fileencoding=utf-8.

I'll update soon.

On 2011/06/30 06:26:51, dsymonds wrote:
> D'oh.
> 
> What about just changing BufRead to BufReadPre?