Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(679)

Issue 4625067: Flag functions instead of defining glyphs directly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Janek Warchol
Modified:
12 years, 9 months ago
Reviewers:
MikeSol, carl.d.sorensen, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Flag functions instead of defining glyphs directly We will need many length variants of every flag. Therefore instead of writing flag code directly in glyph definition, it should be written as a function and called back later as appropriate. The argument shortening is the amount the flag should be shorter than default. As for now it is used in a very primitive way, only to demonstrate the shortening effect and to test c++ code on something.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -29 lines) Patch
M mf/feta-flags.mf View 11 chunks +90 lines, -29 lines 0 comments Download

Messages

Total messages: 4
Janek Warchol
This is an intermediate step that will be needed for shortened flags.
12 years, 10 months ago (2011-06-25 19:34:54 UTC) #1
hanwenn
LGTM (I am assuming the glyphs don't change)
12 years, 10 months ago (2011-06-30 14:06:24 UTC) #2
Carl
lgtm I can see how this will work well for defining a whole set. Carl
12 years, 9 months ago (2011-07-05 05:17:18 UTC) #3
Janek Warchol
12 years, 9 months ago (2011-07-11 08:27:04 UTC) #4
This was just pushed by Mike.
I close the issue.

thanks,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b