Issue 4621044: Modifies Spanner::spanner_length to better handle line-spanners.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4621044: Modifies Spanner::spanner_length to better handle line-spanners. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by MikeSol

Modified:
12 years, 10 months ago

Reviewers:
mike, Graham Percival (old account), Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Modifies Spanner::spanner_length to better handle line-spanners.

Patch Set 1 #

Total comments: 3

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
	M	lily/spanner.cc	View		1 chunk	+19 lines, -4 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

MikeSol

Yes, this is LilyPond patch morning. This should get line-spanners synced up perfectly with Spanner::spanner_length.

12 years, 10 months ago (2011-06-15 07:39:25 UTC) #1

Graham Percival (old account)

thanks, http://code.google.com/p/lilypond/issues/detail?id=1694

12 years, 10 months ago (2011-06-15 08:27:13 UTC) #2

Neil Puttock

LGTM. http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc File lily/spanner.cc (right): http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode243 lily/spanner.cc:243: whitespace http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode249 lily/spanner.cc:249: lr[d] = robust_scm2double (ly_assoc_get (ly_symbol2scm ...

12 years, 10 months ago (2011-06-15 20:39:46 UTC) #3

mike_apollinemike.com

12 years, 10 months ago (2011-06-16 08:36:51 UTC) #4

On Jun 15, 2011, at 10:39 PM, n.puttock@gmail.com wrote:

> LGTM.
> 
> 
> http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc
> File lily/spanner.cc (right):
> 
> http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode243
> lily/spanner.cc:243:
> whitespace
> 
> http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode249
> lily/spanner.cc:249: lr[d] = robust_scm2double (ly_assoc_get
> (ly_symbol2scm ("X"),
> indent:
> 
> do
>  lr[d] = robust_scm2double (ly_assoc_get (ly_symbol2scm ("X"),
> 
> http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode252
> lily/spanner.cc:252:
> whitespace
> 
> http://codereview.appspot.com/4621044/

Clean regtests, so changes made and pushed.
d02c9ba13cc3a7c96cc6374e232e94501a833ed1

Cheers,
MS

Expand All Messages | Collapse All Messages