Issue 4616041: [google] Fix a bug leading to inconsistent comdat group in LIPO mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4616041: [google] Fix a bug leading to inconsistent comdat group in LIPO mode

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by davidxl

Modified:
10 years, 4 months ago

Reviewers:

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/gcc/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	cp/semantics.c	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

davidxl

13 years, 10 months ago (2011-06-14 07:13:14 UTC) #1

The patch will be committed to google/main to fix a problem in LIPO model
that leads to 'reference to discarded comdat section' ld warning. The problem
is caused by inconsistent comdat groups between primary and aux modules because
thunks were skipped in aux module.

2011-06-14   David Li  <davidxl@google.com>

	* cp/semantics.c (emit_associated_thunks):
	Do not omit thunk emission for aux modules.

Index: cp/semantics.c
===================================================================
--- cp/semantics.c	(revision 174851)
+++ cp/semantics.c	(working copy)
@@ -3415,8 +3415,7 @@ emit_associated_thunks (tree fn)
      enabling you to output all the thunks with the function itself.  */
   if (DECL_VIRTUAL_P (fn)
       /* Do not emit thunks for extern template instantiations.  */
-      && ! DECL_REALLY_EXTERN (fn)
-      && ! cgraph_is_auxiliary (fn))
+      && ! DECL_REALLY_EXTERN (fn))
     {
       tree thunk;
 

--
This patch is available for review at http://codereview.appspot.com/4616041

Expand All Messages | Collapse All Messages