Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1064)

Issue 4607043: doc: changing example for overriding positions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Janek Warchol
Modified:
12 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

doc: changing example for overriding positions example in LM 4.5.2 (fixing beam collision) is outdated because beam collision has been implemented, so there is nothing to fix. Therefore I change the type of collision to beam-tie collision.

Patch Set 1 #

Total comments: 8

Patch Set 2 : fixing style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M Documentation/learning/tweaks.itely View 1 1 chunk +28 lines, -15 lines 0 comments Download

Messages

Total messages: 7
Janek Warchol
12 years, 10 months ago (2011-06-12 10:48:42 UTC) #1
Graham Percival (old account)
thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1689
12 years, 10 months ago (2011-06-12 13:33:45 UTC) #2
Graham Percival (old account)
LGTM. Could you send me the final patch for pushing?
12 years, 10 months ago (2011-06-12 13:52:11 UTC) #3
Neil Puttock
http://codereview.appspot.com/4607043/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/4607043/diff/1/Documentation/learning/tweaks.itely#newcode2801 Documentation/learning/tweaks.itely:2801: \time 4/2 judging by the bar checks, I think ...
12 years, 10 months ago (2011-06-12 14:09:09 UTC) #4
Janek Warchol
Style problems corrected. Thanks for review, Neil! http://codereview.appspot.com/4607043/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/4607043/diff/1/Documentation/learning/tweaks.itely#newcode2801 Documentation/learning/tweaks.itely:2801: \time 4/2 ...
12 years, 10 months ago (2011-06-13 11:35:42 UTC) #5
Janek Warchol
2011/6/12 <percival.music.ca@gmail.com>: > LGTM. Could you send me the final patch for pushing? Attached.
12 years, 10 months ago (2011-06-13 11:40:05 UTC) #6
Graham Percival (old account)
12 years, 10 months ago (2011-06-14 12:10:30 UTC) #7
thanks, pushed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b