code review 4605044: mime/multipart: allow for temp files to be removed afte...

mime/multipart: allow for temp files to be removed after tests are finished on Windows

[brainman, 2011-06-11 04:56:23]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitzgoog, 2011-06-11 05:47:56]

LGTM
On Jun 10, 2011 9:56 PM, <alex.brainman@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> mime/multipart: allow for temp files to be removed after tests are
> finished on Windows
>
> Please review this at http://codereview.appspot.com/4605044/
>
> Affected files:
> M src/pkg/mime/multipart/formdata_test.go
>
>
> Index: src/pkg/mime/multipart/formdata_test.go
> ===================================================================
> --- a/src/pkg/mime/multipart/formdata_test.go
> +++ b/src/pkg/mime/multipart/formdata_test.go
> @@ -31,10 +31,12 @@
> if _, ok := fd.(*os.File); ok {
> t.Error("file is *os.File, should not be")
> }
> + fd.Close()
> fd = testFile(t, f.File["fileb"][0], "fileb.txt", filebContents)
> if _, ok := fd.(*os.File); !ok {
> t.Errorf("file has unexpected underlying type %T", fd)
> }
> + fd.Close()
> }
>
> func testFile(t *testing.T, fh *FileHeader, efn, econtent string) File {
>
>

[brainman, 2011-06-11 06:23:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=164ef168486b ***

mime/multipart: allow for temp files to be removed after tests are finished on
Windows

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4605044