Issue 4601053: code review 4601053: xml: allow attributes without value in non-strict mode.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4601053: code review 4601053: xml: allow attributes without value in non-strict mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by volker.dobler

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

xml: allow attributes without value in non-strict mode. Attributes without value are commen in html and the xml parser will accept them in non-strict mode and use the attribute name as value. Thus parsing <p nowrap> as <p norwar="nowrap">.

Patch Set 1 #

Patch Set 2 : diff -r 3180ac267d3d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3180ac267d3d https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -9 lines)			Patch
	M	src/pkg/xml/xml.go	View	1	1 chunk	+14 lines, -9 lines	0 comments	Download
	M	src/pkg/xml/xml_test.go	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

volker.dobler

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2011-06-10 09:08:31 UTC) #1

rsc

This looks great. Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright Thanks. Russ

12 years, 10 months ago (2011-06-14 15:45:29 UTC) #2

volker.dobler

> Please complete a CLA as described at > http://golang.org/doc/contribute.html#copyright > Done! Regards, Volker

12 years, 10 months ago (2011-06-14 16:57:00 UTC) #3

rsc

12 years, 10 months ago (2011-06-16 16:56:55 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=f5d2325ee229 ***

xml: allow attributes without value in non-strict mode.

Attributes without value are commen in html and the xml
parser will accept them in non-strict mode and use the
attribute name as value. Thus parsing <p nowrap> as
<p norwar="nowrap">.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4601053

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages