Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(410)

Issue 4595041: big.nat: Improved speed of nat-to-string conversion

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by mtj
Modified:
13 years, 11 months ago
Reviewers:
gri
CC:
gri, golang-dev
Visibility:
Public.

Description

big.nat: Improved speed of nat-to-string conversion Three optimizations: First, special-case power of two bases that partion a Word(), bases 2, 4, 16, and 256. These can be moved directly from internal Word() storage to the output without multiprecision operations. Next, same approach for the other power-of-two bases, 8, 32, 64, and 128. These don't fill a Word() evenly, so special handling is needed for those cases where input spans the high-bits of one Word and the low bis of the next one. Finally, implement the general case for others bases in 2 <= base <= 256 using superbases, the largest power of base representable in a Word(). For base ten, this is 9 digits and a superbase of 10^9 for 32-bit Words and 19 digits and 10^19 for 64-bit compiles. This way we do just 1/9th or 1/19th of the expensive multiprecision divisions, unpacking superdigits using fast native machine arithmetic. The resulting code runs 7x to 800x the speed of the previous approach, depending on the length of the number to be converted--longer is relatively faster. Also, extended the tests and benchmarks for string to nat (scan()) and nat to string (string()) functions. A further enhancement awaits the next CL to make general cases about 7x faster for long cases.

Patch Set 1 #

Patch Set 2 : diff -r 918d151dbaec https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -18 lines) Patch
M src/pkg/big/nat.go View 1 4 chunks +112 lines, -17 lines 0 comments Download
M src/pkg/big/nat_test.go View 1 4 chunks +212 lines, -1 line 0 comments Download

Messages

Total messages: 3
mtj
ready to go.
13 years, 11 months ago (2011-06-07 22:24:37 UTC) #1
gri
LGTM. (per our off-line review). Fantastic. - gri
13 years, 11 months ago (2011-06-07 22:36:25 UTC) #2
gri
13 years, 11 months ago (2011-06-07 23:02:36 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=082e18eba53b ***

big.nat: Improved speed of nat-to-string conversion

Three optimizations: First, special-case power of two bases
that partion a Word(), bases 2, 4, 16, and 256. These can
be moved directly from internal Word() storage to the output
without multiprecision operations. Next, same approach for
the other power-of-two bases, 8, 32, 64, and 128. These
don't fill a Word() evenly, so special handling is needed
for those cases where input spans the high-bits of one Word
and the low bis of the next one.  Finally, implement the
general case for others bases in 2 <= base <= 256 using
superbases, the largest power of base representable in a
Word(). For base ten, this is 9 digits and a superbase of
10^9 for 32-bit Words and 19 digits and 10^19 for 64-bit
compiles. This way we do just 1/9th or 1/19th of the expensive
multiprecision divisions, unpacking superdigits using fast
native machine arithmetic. The resulting code runs 7x to
800x the speed of the previous approach, depending on the
length of the number to be converted--longer is relatively
faster.

Also, extended the tests and benchmarks for string to nat
(scan()) and nat to string (string()) functions. A further
enhancement awaits the next CL to make general cases about
7x faster for long cases.

R=gri
CC=golang-dev
http://codereview.appspot.com/4595041

Committer: Robert Griesemer <gri@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b