Issue 4591063: code review 4591063: gc: compactframe breaks arm - fix build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4591063: code review 4591063: gc: compactframe breaks arm - fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 11 months ago

Reviewers:

CC:
lvd, golang-dev

Visibility:
Public.

Description

gc: compactframe breaks arm - fix build

Patch Set 1 #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/cmd/gc/pgen.c	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello lvd (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 11 months ago (2011-06-09 22:28:26 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=085523b539c4 *** gc: compactframe breaks arm - fix build R=lvd CC=golang-dev http://codereview.appspot.com/4591063

13 years, 11 months ago (2011-06-09 22:28:29 UTC) #2

lvd

LGTM any idea why? On Fri, Jun 10, 2011 at 00:28, <rsc@golang.org> wrote: > *** ...

13 years, 11 months ago (2011-06-09 22:31:26 UTC) #3

rsc

On Thu, Jun 9, 2011 at 18:31, Luuk van Dijk <lvd@google.com> wrote: > LGTM > ...

13 years, 11 months ago (2011-06-09 22:32:56 UTC) #4

lvd

13 years, 11 months ago (2011-06-10 14:59:54 UTC) #5

On Fri, Jun 10, 2011 at 00:32, Russ Cox <rsc@golang.org> wrote:
> On Thu, Jun 9, 2011 at 18:31, Luuk van Dijk <lvd@google.com> wrote:
>> LGTM
>>
>> any idea why?
>
> No.  Do you have an Ubuntu Lucid box?  You can simulate the failure
> there using qemu.

didn't get qemu-arm to work but inspecting the assembly and adding
some debug statements reveal the problem: the from and to addrs on
arm's progs don't have nodes set, so i have to stare at 5g's ?gen.c
some more.

>
> Russ
>

Expand All Messages | Collapse All Messages