Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1222)

Issue 4584052: Google Breakpad + Crash Reporter (Win + Cmake)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by AlexKu
Modified:
12 years, 10 months ago
Reviewers:
jesterKing, elubie, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

https://projects.blender.org/tracker/index.php?func=detail&aid=27639&group_id=9&atid=127 This patch enables Breakpad on Win + CMake http://wiki.blender.org/index.php/User:AlexK/Breakpad http://cid-257c9a2e9442c94a.skydrive.live.com/redir.aspx?resid=257C9A2E9442C94A!116 Here is win x64 libraries plus windows minidump_stackwalk. win64 *breakpad -*include -*lib *curl -*include -*lib cURL libs are build with /MT and /MTd For breakpadlibx64.patch you must create "breakpad" folder inside win64 due to my svn conflict. Breakpad & cURL distributed with New BSD License and MIT/X derivate license respectively. For release build you must build RelWithDebInfo with WITH_BREAKPAD and WITH_CRASHREPORTER and then run dump_syms. Then upload created symbol file to common repository to be accessible to other developers. WITH_BREAKPAD: Changes 2 Blender source files and adds 2 more. This part generate dump file and then initiate crashreporter.exe. Requires breakpad lib WITH_CRASHREPORTER Provides interface to send the report main.cpp & senddata.cpp should be common on all system. main.cpp calls interface. senddata.cpp composes crash report and sends it. Currently interface available only on windows via win_ui.cpp It uses sui_win, a wrapper under one clause BSD. Requires cURL lib P.S. I changed senddata.cpp but didn't debug it to not spam the tracker. Anyway it should work. I copied error descriptions from MSDN http://msdn.microsoft.com/en-us/library/aa363082%28v=vs.85%29.aspx to be displayed for a user (senddata.cpp). These should be changed also.

Patch Set 1 #

Patch Set 2 : Against current track #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2362 lines, -10 lines) Patch
CMakeLists.txt View 1 3 chunks +19 lines, -0 lines 0 comments Download
build_files/cmake/macros.cmake View 1 2 chunks +9 lines, -0 lines 0 comments Download
build_files/cmake/packaging.cmake View 1 1 chunk +8 lines, -8 lines 0 comments Download
source/blender/CMakeLists.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
source/blender/breakpad/BP_main.h View 1 chunk +10 lines, -0 lines 1 comment Download
source/blender/breakpad/BP_win.cpp View 1 chunk +73 lines, -0 lines 0 comments Download
source/blender/breakpad/CMakeLists.txt View 1 chunk +28 lines, -0 lines 2 comments Download
source/blender/windowmanager/CMakeLists.txt View 1 2 chunks +5 lines, -0 lines 0 comments Download
source/blender/windowmanager/intern/wm_init_exit.c View 1 2 chunks +5 lines, -0 lines 0 comments Download
source/crashreporter/CMakeLists.txt View 1 chunk +41 lines, -0 lines 0 comments Download
source/crashreporter/crashreporter.exe.manifest View 1 chunk +15 lines, -0 lines 0 comments Download
source/crashreporter/main.cpp View 1 chunk +49 lines, -0 lines 0 comments Download
source/crashreporter/senddata.h View 1 chunk +15 lines, -0 lines 0 comments Download
source/crashreporter/senddata.cpp View 1 chunk +363 lines, -0 lines 0 comments Download
source/crashreporter/sui_win/common.h View 1 chunk +13 lines, -0 lines 0 comments Download
source/crashreporter/sui_win/common.cpp View 1 chunk +56 lines, -0 lines 0 comments Download
source/crashreporter/sui_win/sui.h View 1 chunk +261 lines, -0 lines 0 comments Download
source/crashreporter/sui_win/sui.cpp View 1 chunk +1149 lines, -0 lines 0 comments Download
source/crashreporter/ui.h View 1 chunk +2 lines, -0 lines 0 comments Download
source/crashreporter/win_ui.cpp View 1 chunk +216 lines, -0 lines 0 comments Download
source/creator/CMakeLists.txt View 1 4 chunks +11 lines, -0 lines 0 comments Download
source/creator/creator.c View 1 5 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2
AlexKu
12 years, 11 months ago (2011-06-12 18:40:31 UTC) #1
elubie
12 years, 10 months ago (2011-06-27 19:04:28 UTC) #2
I have only been able to look at the blender integration which looks ok to me
apart from missing files ;)

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/BP_ma...
File source/blender/breakpad/BP_main.h (right):

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/BP_ma...
source/blender/breakpad/BP_main.h:6: extern int GBP_finish(void);
These have only implementations for Windows yet. I've seen that you are still
working on the Linux version, so I think it's ok at this stage.

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/CMake...
File source/blender/breakpad/CMakeLists.txt (right):

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/CMake...
source/blender/breakpad/CMakeLists.txt:15: BP_apple.cpp
This file is missing from patch :)

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/CMake...
source/blender/breakpad/CMakeLists.txt:19: BP_linux.cpp
This file is missing from patch as well
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b