Issue 4581058: code review 4581058: go spec: unsafe.Alignof/Offsetof/Sizeof return uintptr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4581058: code review 4581058: go spec: unsafe.Alignof/Offsetof/Sizeof return uintptr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by gri

Modified:
13 years, 10 months ago

Reviewers:

CC:
rsc, iant, r, ken2, golang-dev

Visibility:
Public.

Description

go spec: unsafe.Alignof/Offsetof/Sizeof return uintptr This is (indirectly) a language change. Per e-mail discussion on golang-dev. Fixes issue 1943.

Patch Set 1 #

Patch Set 2 : diff -r 53460e066c2f https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	doc/go_spec.html	View		5 chunks	+15 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello rsc, iant, r, ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...

13 years, 10 months ago (2011-06-13 17:34:29 UTC) #1

gri

13 years, 10 months ago (2011-06-13 23:46:50 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=c06db976d5b3 ***

go spec: unsafe.Alignof/Offsetof/Sizeof return uintptr

This is (indirectly) a language change. Per e-mail discussion
on golang-dev.

Fixes issue 1943.

R=rsc, iant, r, ken
CC=golang-dev
http://codereview.appspot.com/4581058

Expand All Messages | Collapse All Messages