code review 4576065: undo CL 4557047 / 8818ac606e92

undo CL 4557047 / 8818ac606e92

I don't think we've discussed this API enough.

««« original CL description
bike/shed: new package.

It comes up often enough that it's time to provide
the utility of a standard package.

R=r, mirtchovski, adg, rsc, n13m3y3r, ality, go.peter.90, lstoakes, iant, jan.mercl, bsiegert, robert.hencke, rogpeppe, befelemepeseveze, kevlar
CC=golang-dev
http://codereview.appspot.com/4557047
»»»

[rsc, 2011-06-15 21:17:21]

Hello dsymonds (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitz, 2011-06-15 21:18:47]

LGTM

On Wed, Jun 15, 2011 at 2:17 PM, <rsc@golang.org> wrote:

> Reviewers: dsymonds,
>
> Message:
> Hello dsymonds (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> undo CL 4557047 / 8818ac606e92
>
> I don't think we've discussed this API enough.
>
> ««« original CL description
> bike/shed: new package.
>
> It comes up often enough that it's time to provide
> the utility of a standard package.
>
> R=r, mirtchovski, adg, rsc, n13m3y3r, ality, go.peter.90, lstoakes,
> iant, jan.mercl, bsiegert, robert.hencke, rogpeppe, befelemepeseveze,
> kevlar
> CC=golang-dev
> http://codereview.appspot.com/**4557047<http://codereview.appspot.com/4557047>
> »»»
>
> Please review this at
http://codereview.appspot.com/**4576065/<http://codereview.appspot.com/4576065/>
>
> Affected files:
>  M src/pkg/Makefile
>  R src/pkg/bike/shed/Makefile
>  R src/pkg/bike/shed/colors.go
>  R src/pkg/bike/shed/colors_test.**go
>
>
> Index: src/pkg/Makefile
> ==============================**==============================**=======
> --- a/src/pkg/Makefile
> +++ b/src/pkg/Makefile
> @@ -18,7 +18,6 @@
>        archive/zip\
>        asn1\
>        big\
> -       bike/shed\
>        bufio\
>        bytes\
>        cmath\
> Index: src/pkg/bike/shed/Makefile
> ==============================**==============================**=======
> deleted file mode 100644
> --- a/src/pkg/bike/shed/Makefile
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -# Copyright 2011 The Go Authors. All rights reserved.
> -# Use of this source code is governed by a BSD-style
> -# license that can be found in the LICENSE file.
> -
> -include ../../../Make.inc
> -
> -TARG=bike/shed
> -GOFILES=\
> -       colors.go\
> -
> -include ../../../Make.pkg
> Index: src/pkg/bike/shed/colors.go
> ==============================**==============================**=======
> deleted file mode 100644
> --- a/src/pkg/bike/shed/colors.go
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -// Copyright 2011 The Go Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style
> -// license that can be found in the LICENSE file.
> -
> -/*
> -Package shed defines colors for bike sheds.
> -
> -See http://red.bikeshed.org/ for more details.
> -
> -TODO: More colors, colour support, stripes, methods, ponies.
> -*/
> -package shed
> -
> -// A Color represents a color, or a colour if you're colonial enough.
> -type Color uint8
> -
> -const (
> -       Red Color = iota
> -       Green
> -       Yellow
> -       Blue
> -       Purple
> -       Magenta
> -       Chartreuse
> -       Cyan
> -)
> Index: src/pkg/bike/shed/colors_test.**go
> ==============================**==============================**=======
> deleted file mode 100644
> --- a/src/pkg/bike/shed/colors_**test.go
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -// Copyright 2011 The Go Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style
> -// license that can be found in the LICENSE file.
> -
> -package shed
> -
> -import (
> -       "testing"
> -)
> -
> -func TestCompilerIsNotColorBlind(t *testing.T) {
> -       if Red == Green {
> -               t.Error("Expected Red != Green, but couldn't distinguish
> them")
> -       }
> -}
>
>
>

[gri, 2011-06-15 21:32:29]

LGTM

ps: w/o i18n this api is not going anywhere

On Wed, Jun 15, 2011 at 2:17 PM,  <rsc@golang.org> wrote:
> Reviewers: dsymonds,
>
> Message:
> Hello dsymonds (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> undo CL 4557047 / 8818ac606e92
>
> I don't think we've discussed this API enough.
>
> ««« original CL description
> bike/shed: new package.
>
> It comes up often enough that it's time to provide
> the utility of a standard package.
>
> R=r, mirtchovski, adg, rsc, n13m3y3r, ality, go.peter.90, lstoakes,
> iant, jan.mercl, bsiegert, robert.hencke, rogpeppe, befelemepeseveze,
> kevlar
> CC=golang-dev
> http://codereview.appspot.com/4557047
> »»»
>
> Please review this at http://codereview.appspot.com/4576065/
>
> Affected files:
>  M src/pkg/Makefile
>  R src/pkg/bike/shed/Makefile
>  R src/pkg/bike/shed/colors.go
>  R src/pkg/bike/shed/colors_test.go
>
>
> Index: src/pkg/Makefile
> ===================================================================
> --- a/src/pkg/Makefile
> +++ b/src/pkg/Makefile
> @@ -18,7 +18,6 @@
>        archive/zip\
>        asn1\
>        big\
> -       bike/shed\
>        bufio\
>        bytes\
>        cmath\
> Index: src/pkg/bike/shed/Makefile
> ===================================================================
> deleted file mode 100644
> --- a/src/pkg/bike/shed/Makefile
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -# Copyright 2011 The Go Authors. All rights reserved.
> -# Use of this source code is governed by a BSD-style
> -# license that can be found in the LICENSE file.
> -
> -include ../../../Make.inc
> -
> -TARG=bike/shed
> -GOFILES=\
> -       colors.go\
> -
> -include ../../../Make.pkg
> Index: src/pkg/bike/shed/colors.go
> ===================================================================
> deleted file mode 100644
> --- a/src/pkg/bike/shed/colors.go
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -// Copyright 2011 The Go Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style
> -// license that can be found in the LICENSE file.
> -
> -/*
> -Package shed defines colors for bike sheds.
> -
> -See http://red.bikeshed.org/ for more details.
> -
> -TODO: More colors, colour support, stripes, methods, ponies.
> -*/
> -package shed
> -
> -// A Color represents a color, or a colour if you're colonial enough.
> -type Color uint8
> -
> -const (
> -       Red Color = iota
> -       Green
> -       Yellow
> -       Blue
> -       Purple
> -       Magenta
> -       Chartreuse
> -       Cyan
> -)
> Index: src/pkg/bike/shed/colors_test.go
> ===================================================================
> deleted file mode 100644
> --- a/src/pkg/bike/shed/colors_test.go
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -// Copyright 2011 The Go Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style
> -// license that can be found in the LICENSE file.
> -
> -package shed
> -
> -import (
> -       "testing"
> -)
> -
> -func TestCompilerIsNotColorBlind(t *testing.T) {
> -       if Red == Green {
> -               t.Error("Expected Red != Green, but couldn't distinguish
> them")
> -       }
> -}
>
>
>

[dsymonds, 2011-06-15 21:49:38]

LGTM

[rsc, 2011-06-15 23:48:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=6c9c33c799f1 ***

undo CL 4557047 / 8818ac606e92

I don't think we've discussed this API enough.

««« original CL description
bike/shed: new package.

It comes up often enough that it's time to provide
the utility of a standard package.

R=r, mirtchovski, adg, rsc, n13m3y3r, ality, go.peter.90, lstoakes, iant,
jan.mercl, bsiegert, robert.hencke, rogpeppe, befelemepeseveze, kevlar
CC=golang-dev
http://codereview.appspot.com/4557047
»»»

R=dsymonds, bradfitz, gri
CC=golang-dev
http://codereview.appspot.com/4576065