Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2432)

Issue 4576061: Glissandi have no padding at line breaks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by MikeSol
Modified:
12 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Glissandi have no padding at line breaks.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M scm/define-grobs.scm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
MikeSol
An aesthetic issue, but it seems to me that this is in better keeping with ...
12 years, 10 months ago (2011-06-15 07:18:21 UTC) #1
Graham Percival (old account)
On 2011/06/15 07:18:21, MikeSol wrote: > An aesthetic issue, but it seems to me that ...
12 years, 10 months ago (2011-06-15 08:28:53 UTC) #2
mike_apollinemike.com
12 years, 10 months ago (2011-06-15 08:32:37 UTC) #3
On Jun 15, 2011, at 10:28 AM, percival.music.ca@gmail.com wrote:

> On 2011/06/15 07:18:21, MikeSol wrote:
>> An aesthetic issue,  but it seems to me that this is in better keeping
> with what
>> a glissando represents.
> 
> What kind of padding does it use now?
> 
> I have a vague recollection of somebody complaining that the glissando
> ran directly into the bar line and that made it harder to read.  That
> was back in 2003 or 2004 or something like that.
> 
> code-wise it certainly LGTM.  :)

It uses a padding of 1.5 across the board, including at barlines.
It is not a big deal if this doesn't get pushed - its a "I've used this as a
default more often than not, ergo, I'm thinking that it may be worth bringing up
the issue" patch.  If people like the padding, I'll just keep it in my
meister-lily-tweak file.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b