Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(105)

Issue 4576042: code review 4576042: template: rearrange the code into separate files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by r
Modified:
13 years, 11 months ago
Reviewers:
CC:
golang-dev, r2, gri
Visibility:
Public.

Description

template: rearrange the code into separate files. The single file was getting unwieldy. Also remove use of vector; a slice works fine - although it's an unusual one.

Patch Set 1 #

Patch Set 2 : diff -r 6131be50e97d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1183 lines, -1162 lines) Patch
M src/pkg/template/Makefile View 1 chunk +3 lines, -1 line 0 comments Download
A src/pkg/template/doc.go View 1 chunk +91 lines, -0 lines 0 comments Download
A src/pkg/template/execute.go View 1 chunk +346 lines, -0 lines 0 comments Download
A src/pkg/template/parse.go View 1 chunk +743 lines, -0 lines 0 comments Download
R src/pkg/template/template.go View 1 chunk +0 lines, -1161 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-06-05 23:42:36 UTC) #1
r2
P.S. other than removing vector, this was pure file rearrangement. no semantic changes.
13 years, 11 months ago (2011-06-05 23:43:25 UTC) #2
gri
LGTM
13 years, 11 months ago (2011-06-06 18:40:30 UTC) #3
r
13 years, 11 months ago (2011-06-06 21:33:12 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=16741d5e6706 ***

template: rearrange the code into separate files.
The single file was getting unwieldy.
Also remove use of vector; a slice works fine - although
it's an unusual one.

R=golang-dev, r, gri
CC=golang-dev
http://codereview.appspot.com/4576042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b