Issue 4575055: [pph] Front-end builtin macros

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4575055: [pph] Front-end builtin macros (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by Lawrence Crowl

Modified:
13 years, 3 months ago

Reviewers:
Diego Novillo

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/pph/

Visibility:
Public.

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -8 lines)			Patch
M	gcc/testsuite/g++.dg/pph/c120060625-1.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	gcc/testsuite/g++.dg/pph/c120060625-1.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	libcpp/symtab.c	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Lawrence Crowl

Some builtin macros are more builtin than others. In particular, front-end builtin macros are weaker ...

14 years, 2 months ago (2011-06-08 22:09:28 UTC) #1

Some builtin macros are more builtin than others.  In particular, front-end
builtin macros are weaker than libcpp builtin macros, and should not be
processed with the libcpp builtin tools.


Index: gcc/testsuite/ChangeLog.pph

2011-06-08  Lawrence Crowl <crowl@google.com>

	* g++.dg/pph/c120060625-1.h: Make expected pass.
	* g++.dg/pph/c120060625-1.cc: Make expected pass.

Index: libcpp/ChangeLog.pph

2011-06-08  Lawrence Crowl  <crowl@google.com>

	* symtab.c (lt_query_macro): Querying "user builtin" macros should not
	call _cpp_builtin_macro_text.  Instead, call regular query, but first
	let the front end define the value.


Index: gcc/testsuite/g++.dg/pph/c120060625-1.cc
===================================================================
--- gcc/testsuite/g++.dg/pph/c120060625-1.cc	(revision 174789)
+++ gcc/testsuite/g++.dg/pph/c120060625-1.cc	(working copy)
@@ -1,5 +1 @@
-// { dg-xfail-if "ICE" { "*-*-*" } { "-fpph-map=pph.map" } }
-// { dg-bogus "c120060625-1.h:14:22: internal compiler error: invalid built-in
macro .__FLT_MAX__." "" { xfail *-*-* } 0 }
-// { dg-prune-output "In file included from " }
-
 #include "c120060625-1.h"
Index: gcc/testsuite/g++.dg/pph/c120060625-1.h
===================================================================
--- gcc/testsuite/g++.dg/pph/c120060625-1.h	(revision 174789)
+++ gcc/testsuite/g++.dg/pph/c120060625-1.h	(working copy)
@@ -1,6 +1,3 @@
-// { dg-xfail-if "ICE" { "*-*-*" } { "-fpph-map=pph.map" } }
-// { dg-bogus "c120060625-1.h:14:22: internal compiler error: invalid built-in
macro .__FLT_MAX__." "" { xfail *-*-* } 0 }
-
 #ifndef __PPH_GUARD_H
 #define __PPH_GUARD_H
 
Index: libcpp/symtab.c
===================================================================
--- libcpp/symtab.c	(revision 174789)
+++ libcpp/symtab.c	(working copy)
@@ -494,7 +494,8 @@ static const char *
 lt_query_macro (cpp_reader *reader, cpp_hashnode *cpp_node)
 {
   const char *definition = NULL;
-  if (cpp_node->flags & NODE_BUILTIN)
+  if ((cpp_node->flags & NODE_BUILTIN)
+      && cpp_node->value.builtin < BT_FIRST_USER)
     {
       const char *str = (const char *)cpp_node->ident.str;
       if (   strcmp(str, "__DATE__") == 0
@@ -527,6 +528,8 @@ lt_query_macro (cpp_reader *reader, cpp_
   else
     {
       char c;
+      if ((cpp_node->flags & NODE_BUILTIN) && reader->cb.user_builtin_macro)
+        reader->cb.user_builtin_macro (reader, cpp_node);
       definition = (const char *) cpp_macro_definition (reader, cpp_node);
       /* Skip over the macro name within the definition.  */
       c = *definition;

--
This patch is available for review at http://codereview.appspot.com/4575055

Diego Novillo

14 years, 2 months ago (2011-06-08 22:22:14 UTC) #2

On Wed, Jun 8, 2011 at 15:09, Lawrence Crowl <crowl@google.com> wrote:
> Some builtin macros are more builtin than others.  In particular, front-end
> builtin macros are weaker than libcpp builtin macros, and should not be
> processed with the libcpp builtin tools.

Nice!  This fixes a whole chunk of C test cases.


Diego.

Expand All Messages | Collapse All Messages