Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1760)

Issue 4575044: More gyp cleanup, win32 fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Stephen White
Modified:
12 years, 11 months ago
Reviewers:
epoger, bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove some files from views.gyp that already being compiled into utils.gyp (already done for Linux, this change does the same for Mac and Win).

Patch Set 1 #

Patch Set 2 : Add fix for spurious rebuilds in images.gyp, delete[] fix #

Patch Set 3 : Remove SampleApp.gyp changes (removes more spurious rebuilds, but crashes at runtime in SampleGM). #

Patch Set 4 : Update #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
gyp/core.gyp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
gyp/images.gyp View 1 2 3 1 chunk +0 lines, -3 lines 3 comments Download
gyp/views.gyp View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 10
Stephen White
12 years, 11 months ago (2011-06-06 19:41:10 UTC) #1
Stephen White
Add fix for spurious rebuilds in images.gyp, delete[] fix
12 years, 11 months ago (2011-06-06 19:55:32 UTC) #2
Stephen White
Remove SampleApp.gyp changes (removes more spurious rebuilds, but crashes at runtime in SampleGM).
12 years, 11 months ago (2011-06-06 20:05:04 UTC) #3
Stephen White
ping?
12 years, 11 months ago (2011-06-07 16:30:57 UTC) #4
Stephen White
Update
12 years, 11 months ago (2011-06-20 19:28:13 UTC) #5
epoger
LGTM If it does indeed build/run on all platforms, I'm all for it... http://codereview.appspot.com/4575044/diff/16001/gyp/images.gyp File ...
12 years, 11 months ago (2011-06-20 19:37:26 UTC) #6
bsalomon
http://codereview.appspot.com/4575044/diff/16001/gyp/images.gyp File gyp/images.gyp (left): http://codereview.appspot.com/4575044/diff/16001/gyp/images.gyp#oldcode100 gyp/images.gyp:100: 'sources': [ On 2011/06/20 19:37:26, epoger wrote: > Are ...
12 years, 11 months ago (2011-06-20 20:36:52 UTC) #7
epoger
link_settings is a misleading name for that section. What that really means is, "targets that ...
12 years, 11 months ago (2011-06-20 20:46:21 UTC) #8
Stephen White
http://codereview.appspot.com/4575044/diff/16001/gyp/images.gyp File gyp/images.gyp (left): http://codereview.appspot.com/4575044/diff/16001/gyp/images.gyp#oldcode100 gyp/images.gyp:100: 'sources': [ On 2011/06/20 20:36:52, bsalomon wrote: > On ...
12 years, 11 months ago (2011-06-21 14:50:57 UTC) #9
Stephen White
12 years, 11 months ago (2011-06-27 17:45:28 UTC) #10
Landed as r1654.  Closing (forgot this one).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b