Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 4572055: [google] cprop pass's gate function cleanup

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by davidxl
Modified:
10 years, 4 months ago
Reviewers:
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/gcc/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M gcse.c View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 1
davidxl
13 years, 10 months ago (2011-06-09 20:28:49 UTC) #1
The patch fixed the breakage due to the r174848 backport to google/main --
the gate function for cprop is in a different file from trunk.

2011-06-09  David Li  <davidxl@google.com>

	* gcse.c (gate_rtl_cprop): Gate cleanup
	(execute_rtl_cprop): Gate cleanup

Index: gcse.c
===================================================================
--- gcse.c	(revision 174852)
+++ gcse.c	(working copy)
@@ -5309,15 +5309,17 @@ one_cprop_pass (void)
 static bool
 gate_rtl_cprop (void)
 {
-  return optimize > 0 && flag_gcse
-    && !cfun->calls_setjmp
-    && dbg_cnt (cprop);
+  return optimize > 0 && flag_gcse;
 }
 
 static unsigned int
 execute_rtl_cprop (void)
 {
   int changed;
+  if (cfun->calls_setjmp
+      || !dbg_cnt (cprop))
+    return 0;
+
   delete_unreachable_blocks ();
   df_set_flags (DF_LR_RUN_DCE);
   df_analyze ();

--
This patch is available for review at http://codereview.appspot.com/4572055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b