Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(863)

Issue 4571080: Property setting in lyrics: allow markup, not just bare strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by Neil Puttock
Modified:
12 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Property setting in lyrics: allow markup * input/regression/stanza-number.ly: test markup as well as bare string * lily/parser.yy (scalar): use lyric_element instead of LYRICS_STRING

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M input/regression/stanza-number.ly View 2 chunks +6 lines, -9 lines 0 comments Download
M lily/parser.yy View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Neil Puttock
Prompted by this thread on lilypond-user-fr: http://lists.gnu.org/archive/html/lilypond-user-fr/2011-06/msg00048.html Currently, the following code will fail with a ...
12 years, 9 months ago (2011-06-15 22:24:39 UTC) #1
Trevor Daniels
LGTM
12 years, 9 months ago (2011-06-16 07:46:08 UTC) #2
Graham Percival (old account)
LGTM. I won't bother with an issue tracker item for this; I think it's simple+clear ...
12 years, 9 months ago (2011-06-16 16:28:45 UTC) #3
Neil Puttock
12 years, 9 months ago (2011-06-18 22:43:58 UTC) #4
On 16 June 2011 17:28,  <percival.music.ca@gmail.com> wrote:

> I won't bother with an issue tracker item for this; I think it's
> simple+clear enough that it can be pushed without a full "patch
> countdown".

Thanks, pushed: eb307731804e61efcb62a13ebbf13da5bb050f3f

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b