Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6177)

Issue 4568046: Doc: NR 1.6.3 Added cueDuringWithClef (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by pkx166h
Modified:
12 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR 1.6.3 Added cueDuringWithClef and cueClef Documented how to use cueDuringWithClef Tracker issue 1658 Also updated some of the original examples to differentiate between strings used for music and those used for the variables in order to make the examples clearer Added appropriate @funindex Also moved \killcues to the end as it seemed more appropriate to have 'how to create all the cue stuff' first and then how to 'kill' them at the end. Also added an @knownissue about making sure that certain arguments are in the correct order.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Draft 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -52 lines) Patch
M Documentation/notation/staff.itely View 1 8 chunks +80 lines, -52 lines 0 comments Download

Messages

Total messages: 5
Graham Percival (old account)
LGTM, wait maybe a day then push.
12 years, 11 months ago (2011-06-01 22:29:49 UTC) #1
Trevor Daniels
LGTM, apart from minor changes noted http://codereview.appspot.com/4568046/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4568046/diff/1/Documentation/notation/staff.itely#newcode1285 Documentation/notation/staff.itely:1285: g4. b8 d2 ...
12 years, 11 months ago (2011-06-02 07:10:26 UTC) #2
pkx166h
Second Draft I also just want to check with Reinhold as all I have done ...
12 years, 11 months ago (2011-06-02 09:18:06 UTC) #3
Reinhold
On 2011/06/02 09:18:06, J_lowe wrote: > Second Draft > > I also just want to ...
12 years, 11 months ago (2011-06-02 13:27:38 UTC) #4
pkx166h
12 years, 10 months ago (2011-06-06 15:19:07 UTC) #5
Pushed as 

ffd9d60d597d14bef71efed7b623ab4a93efb12

Solved this one I'll update the tracker. Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b