Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 4560043: Issue 2: TextFSM should leave file pointer at top of template file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by harro
Modified:
14 years, 11 months ago
Reviewers:
bbuxton, jdoak
CC:
textfsm-dev_googlegroups.com
Base URL:
http://textfsm.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make use of finally clause #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M textfsm.py View 1 1 chunk +5 lines, -1 line 0 comments Download
M textfsm_test.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bbuxton
http://codereview.appspot.com/4560043/diff/1/textfsm.py File textfsm.py (right): http://codereview.appspot.com/4560043/diff/1/textfsm.py#newcode529 textfsm.py:529: except TextFSMTemplateError, error: finally? I think it's reasonable to ...
15 years ago (2011-05-26 05:09:16 UTC) #1
harro
http://codereview.appspot.com/4560043/diff/1/textfsm.py File textfsm.py (right): http://codereview.appspot.com/4560043/diff/1/textfsm.py#newcode529 textfsm.py:529: except TextFSMTemplateError, error: On 2011/05/26 05:09:16, bbuxton wrote: > ...
15 years ago (2011-06-03 04:48:49 UTC) #2
bbuxton
15 years ago (2011-06-03 08:00:16 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b