code review 4559059: net: stop Mac popups

net: stop Mac popups

[rsc, 2011-05-31 19:40:04]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitzgoog, 2011-05-31 20:07:16]

LGTM

On Tue, May 31, 2011 at 12:40 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> net: stop Mac popups
>
> Please review this at http://codereview.appspot.com/4559059/
>
> Affected files:
>  M src/pkg/net/server_test.go
>
>
> Index: src/pkg/net/server_test.go
> ===================================================================
> --- a/src/pkg/net/server_test.go
> +++ b/src/pkg/net/server_test.go
> @@ -92,10 +92,13 @@
>  }
>
>  func doTest(t *testing.T, network, listenaddr, dialaddr string) {
> -       if listenaddr == "" {
> -               t.Logf("Test %s %s %s\n", network, "<nil>", dialaddr)
> -       } else {
> -               t.Logf("Test %s %s %s\n", network, listenaddr, dialaddr)
> +       t.Logf("Test %q %q %q\n", network, listenaddr, dialaddr)
> +       switch listenaddr {
> +       case "", "0.0.0.0", "[::]", "[::ffff:0.0.0.0]":
> +               if testing.Short() {
> +                       t.Logf("skip wildcard listen during short test")
> +                       return
> +               }
>        }
>        listening := make(chan string)
>        done := make(chan int)
>
>
>

[rsc, 2011-05-31 20:15:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=0f3cb0fbb6ff ***

net: stop Mac popups

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4559059