Issue 4556060: code review 4556060: fmt: make %q work for integers, printing a quoted chara...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4556060: code review 4556060: fmt: make %q work for integers, printing a quoted chara... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by r

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

fmt: make %q work for integers, printing a quoted character literal.

Patch Set 1 #

Patch Set 2 : diff -r e26c8906b005 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 38618180157b https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
M	src/pkg/fmt/doc.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/fmt/fmt_test.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/format.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/print.go	View	1	3 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-05-25 04:43:24 UTC) #1

rsc1

Possible that %q of 100000000 should be %q(int=1000000000)

13 years, 11 months ago (2011-05-25 04:59:45 UTC) #3

Hello golang-dev@googlegroups.com, rsc@google.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 11 months ago (2011-05-25 05:07:21 UTC) #4

13 years, 11 months ago (2011-05-25 11:25:23 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=256b31ceb2e2 ***

fmt: make %q work for integers, printing a quoted character literal.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4556060

Expand All Messages | Collapse All Messages