code review 4553052: asn1: fix marshalling of optional RawValues

asn1: fix marshalling of empty optional RawValues

This fixes creation of X509 certificates with
RSA keys. (Broken by e5ecc416f2fd)

[mkrautz, 2011-05-20 17:36:18]

Hello agl@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[agl1, 2011-05-20 17:42:10]

On Fri, May 20, 2011 at 10:36 AM,  <krautz@gmail.com> wrote:
> Description:
> asn1: fix marshalling of optional RawValues

I think I've actually just fixed this in the tree inadvertently
because I was working on something else. But I think your patch is
better.

It'll be this evening before I can get around to checking though.


Cheers

AGL

[mkrautz, 2011-05-20 18:15:45]

On 2011/05/20 17:42:10, agl1 wrote:
> I think I've actually just fixed this in the tree inadvertently
> because I was working on something else. But I think your patch is
> better.

I just checked, and the change from the big changeset does indeed fix the issue
also.

I've removed that one, and kept the one my original patch moved near the top of
marshalField.

PTAL.

[agl1, 2011-06-01 16:54:44]

*** Submitted as http://code.google.com/p/go/source/detail?r=334b588b4e4f ***

asn1: fix marshalling of empty optional RawValues

This fixes creation of X509 certificates with
RSA keys. (Broken by e5ecc416f2fd)

R=agl
CC=golang-dev
http://codereview.appspot.com/4553052

Committer: Adam Langley <agl@golang.org>