Issue 4553051: code review 4553051: syscall: sendfile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4553051: code review 4553051: syscall: sendfile (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by bradfitz

Modified:
13 years, 11 months ago

Reviewers:

CC:
iant, golang-dev

Visibility:
Public.

Description

syscall: sendfile

Patch Set 1 #

Patch Set 2 : diff -r 561d9021e7a4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 561d9021e7a4 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 561d9021e7a4 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 364e36aeec98 https://go.googlecode.com/hg #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -1 line)			Patch
M	src/pkg/syscall/syscall_darwin.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_freebsd.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/syscall/syscall_linux_386.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_amd64.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_arm.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_plan9.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_windows.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_386.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_amd64.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_arm.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-05-20 17:26:25 UTC) #1

bradfitz

Hello iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 11 months ago (2011-05-20 17:38:58 UTC) #2

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=dbfa667d4da2 *** syscall: sendfile R=iant CC=golang-dev http://codereview.appspot.com/4553051

13 years, 11 months ago (2011-05-20 18:51:35 UTC) #4

bradfitz

13 years, 11 months ago (2011-05-20 18:53:24 UTC) #5

(test built on {darwin,linux}/amd64, linux/386 ...)

On Fri, May 20, 2011 at 11:51 AM, <bradfitz@golang.org> wrote:

> *** Submitted as
> http://code.google.com/p/go/source/detail?r=dbfa667d4da2 ***
>
> syscall: sendfile
>
> R=iant
> CC=golang-dev
>
> http://codereview.appspot.com/4553051
>
>
> http://codereview.appspot.com/4553051/
>

Expand All Messages | Collapse All Messages