Issue 4551057: code review 4551057: image/gif: simplify blockReader.Read.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4551057: code review 4551057: image/gif: simplify blockReader.Read. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by r

Modified:
13 years, 11 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

image/gif: simplify blockReader.Read. Inverting the tests avoids recursion and simplifies the flow.

Patch Set 1 #

Patch Set 2 : diff -r b683b10bb780 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 58102fac10c6 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -19 lines)			Patch
	M	src/pkg/image/gif/reader.go	View	1	1 chunk	+17 lines, -19 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello nigeltao (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-05-23 05:15:53 UTC) #1

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 11 months ago (2011-05-24 00:02:40 UTC) #2

13 years, 11 months ago (2011-05-24 01:02:51 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=2d3e41aeb1b3 ***

image/gif: simplify blockReader.Read.
Inverting the tests avoids recursion and simplifies the flow.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/4551057

Expand All Messages | Collapse All Messages