Redirects lilypond output to reduce make doc noise

Redirects lilypond output to reduce make doc noise

Redirects the output from lilypond when lily is run from lilypond-book
as part of make doc.  Normal output goes to *.log, error output to
*.err.log.

Note that this looks more complex than needed, since redirecting output
appears to stop normal process monitoring, so I've had to use process.poll.
I have tested this, and a polling rate of once per second does not 
slow compilation significantly - most files take 100s of seconds to compile.

[PhilEHolmes, 2011-06-07 14:34:30]

Please review this proposed change to the build system.
The change reduces the amount of un-needed information
echoed to the screen during make doc.

[Graham Percival (old account), 2011-06-07 15:11:01]

hmm, on my machine this creates a log file like:
  snippets-names-173988768 .err.log
(note the space)
in the main dir.  Instead of that, could we:
1) not have a space
2) direct the log for each file to the corresponding .ly file?  I mean, I see
  15/lily-f332c4db.ly
(you'll have different numbers for your stuff)

I'd like the output for
  15/lily-f332c4db.ly
to be written to
  15/lily-f332c4db.err.log
  15/lily-f332c4db.log
(maybe even .std.log ?)


it might also be good to consider the lilypond-book (and lilylib) patch
separately from the build system.  For example, just test it with
  out/bin/lilypond-book foo.tely
(after making a foo.tely) and make sure the log files work with that.  Then,
once the lilypond-book patch is pushed, add it to the build system.

[email_philholmes.net, 2011-06-07 15:23:53]

----- Original Message ----- 
From: <percival.music.ca@gmail.com>
To: <PhilEHolmes@googlemail.com>
Cc: <lilypond-devel@gnu.org>; <reply@codereview.appspotmail.com>
Sent: Tuesday, June 07, 2011 4:11 PM
Subject: Re: Redirects lilypond output to reduce make doc noise 
(issue4550119)


> hmm, on my machine this creates a log file like:
>   snippets-names-173988768 .err.log
> (note the space)
> in the main dir.  Instead of that, could we:
> 1) not have a space


The space is a bug that I'd not noticed - it comes from using the .join() 
function to concatenate, which is faster but since I copied another line 
which used ' '.join and not ''.join, then you get the added space.  You get 
the same for the logfile.  I think I can correct this by simply correcting 
the relevant file, create a new patch and re-upload?  This will upload the 
full set of changes, not just the correction for this bug.

> 2) direct the log for each file to the corresponding .ly file?  I mean,
> I see
>   15/lily-f332c4db.ly
> (you'll have different numbers for your stuff)
> I'd like the output for
>   15/lily-f332c4db.ly
> to be written to
>   15/lily-f332c4db.err.log
>   15/lily-f332c4db.log
> (maybe even .std.log ?)


I don't know how you'd do this.  AFAICS there is only a single call to 
lilypond with the command line being the snippet-names file.  This file has 
a long list of "included" lilypond files, which I presume lilypond processes 
internally.  There is therefore no separate output to redirect.

> it might also be good to consider the lilypond-book (and lilylib) patch
> separately from the build system.  For example, just test it with
>   out/bin/lilypond-book foo.tely
> (after making a foo.tely) and make sure the log files work with that.
> Then, once the lilypond-book patch is pushed, add it to the build
> system.
>
>
>
> http://codereview.appspot.com/4550119/

That's how I did my testing.  TBH the change to the build system 
(effectively adding one word) is so small it's not worth separating them.

--
Phil Holmes

[Graham Percival (old account), 2011-06-07 23:00:25]

On 2011/06/07 15:23:53, email_philholmes.net wrote:
> I think I can correct this by simply correcting 
> the relevant file, create a new patch and re-upload?

Please do "amend previous commit" instead, but yes, that's how to do it.

> This will upload the 
> full set of changes, not just the correction for this bug.

Yes, but the reitveld interface takes care of that.
 
> >   15/lily-f332c4db.ly
> > to be written to
> >   15/lily-f332c4db.log
> 
> I don't know how you'd do this.  AFAICS there is only a single call to 
> lilypond with the command line being the snippet-names file.

Ouch.  ok, so the way that it would be done would be by screwing around in the
scm/ or possibly even lily/ dir.  Forget it; that's too much work for you and
me.

(if somebody else wants to jump in and handle that stuff, that'd be great!  But
even without that, Phil's patch is a huge improvement over the status quo, so
we'll proceed with it)

> TBH the change to the build system 
> (effectively adding one word) is so small it's not worth separating them.

True.
 

ok, just make that one change, upload, and it should be good.

Cheers,
- Graham

[PhilEHolmes, 2011-06-08 14:44:07]

Following comments, I hope this is good to go.

[Graham Percival (old account), 2011-06-08 16:27:52]

LGTM.  I'll include it in the next patches countdown.