Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 4550111: code review 4550111: exec: missing docs, errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by bradfitz
Modified:
13 years, 11 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

exec: missing docs, errors

Patch Set 1 #

Patch Set 2 : diff -r 8ec69353bb78 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8ec69353bb78 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r a76c2f42924d https://go.googlecode.com/hg #

Patch Set 5 : diff -r a76c2f42924d https://go.googlecode.com/hg #

Patch Set 6 : diff -r 1ad9c6bde8e3 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M src/pkg/exec/exec.go View 1 2 3 4 6 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 7
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-06-02 14:52:09 UTC) #1
rsc
LGTM http://codereview.appspot.com/4550111/diff/5001/src/pkg/exec/exec.go File src/pkg/exec/exec.go (right): http://codereview.appspot.com/4550111/diff/5001/src/pkg/exec/exec.go#newcode201 src/pkg/exec/exec.go:201: // Start starts the specified command but does ...
13 years, 11 months ago (2011-06-02 15:04:05 UTC) #2
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2011-06-02 16:34:11 UTC) #3
bradfitz
Also made a double-Wait an error, to catch accidental Wait-after-Run. On Thu, Jun 2, 2011 ...
13 years, 11 months ago (2011-06-02 16:34:58 UTC) #4
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2011-06-02 16:35:48 UTC) #5
rsc
LGTM
13 years, 11 months ago (2011-06-02 16:56:07 UTC) #6
bradfitz
13 years, 11 months ago (2011-06-02 16:57:27 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=4bccc451c643 ***

exec: missing docs, errors

R=rsc
CC=golang-dev
http://codereview.appspot.com/4550111
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b