Issue 4550108: Fix for [#27410] Manual save kills actual .blend file if disk space is low

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4550108: Fix for [#27410] Manual save kills actual .blend file if disk space is low (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by elubie

Modified:
12 years, 11 months ago

Reviewers:
brechtvl, ideasman42, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

This moves the do_history into the BLO_write_file, so the file renaming happens after successful write of the temporary .blend@ file. Added new file flag, to avoid writing history on writing the homefile and undo.

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+83 lines, -63 lines)			Patch
source/blender/blenkernel/BKE_global.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
source/blender/blenkernel/intern/blender.c	View	2 chunks	+3 lines, -2 lines	0 comments	Download
source/blender/blenloader/intern/writefile.c	View	2 chunks	+73 lines, -31 lines	0 comments	Download
source/blender/windowmanager/intern/wm_files.c	View	5 chunks	+6 lines, -30 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Committed to svn, rev. 37098, thanks for review.

Expand All Messages | Collapse All Messages