Issue 4550089: code review 4550089: codereview: add codereview

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4550089: code review 4550089: codereview: add codereview (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by npe

Modified:
14 years, 4 months ago

Reviewers:

CC:
npe, inferno-npe_googlegroups.com

Visibility:
Public.

Description

codereview: add codereview this is my first test of code review. Adding the codereview scripts to inferno-npe.

Patch Set 1 #

Patch Set 2 : diff -r 39f6fb5aae70 https://inferno-npe.googlecode.com/hg/ #

Patch Set 3 : diff -r 39f6fb5aae70 https://inferno-npe.googlecode.com/hg/ #

Patch Set 4 : diff -r 39f6fb5aae70 https://inferno-npe.googlecode.com/hg/ #

Patch Set 5 : diff -r 39f6fb5aae70 https://inferno-npe.googlecode.com/hg/ #

Patch Set 6 : diff -r 39f6fb5aae70 https://inferno-npe.googlecode.com/hg/ #

Patch Set 7 : diff -r 39f6fb5aae70 https://inferno-npe.googlecode.com/hg/ #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3279 lines, -0 lines)			Patch
A	utils/lib/codereview/codereview.cfg	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	utils/lib/codereview/codereview.py	View	1 2 3 4 5	1 chunk	+3278 lines, -0 lines	0 comments	Download
A	utils/lib/codereview/codereview.pyc	View	1 2 3 4 5	Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

npe

Hello noah.evans@gmail.com (cc: golang-dev@googlegroups.com, noah.evans@gmail.com), I'd like you to review this change to https://inferno-npe.googlecode.com/hg/

14 years, 4 months ago (2011-05-27 13:20:23 UTC) #1

npe

14 years, 4 months ago (2011-05-30 07:46:52 UTC) #3

*** Submitted as
http://code.google.com/p/inferno-npe/source/detail?r=0f74441d8848 ***

codereview: add codereview

this is my first test of code review. Adding the codereview scripts to
inferno-npe.

R=noah.evans
CC=inferno-npe, noah.evans
http://codereview.appspot.com/4550089

Expand All Messages | Collapse All Messages