Issue 4548085: code review 4548085: math: add ARMv7 VFP specfic sqrt and fabs functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4548085: code review 4548085: math: add ARMv7 VFP specfic sqrt and fabs functions

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by fango

Modified:
12 years, 11 months ago

Reviewers:
golang-dev

CC:
golang-dev, rsc

Visibility:
Public.

Description

math: add ARMv7 VFP specfic sqrt and fabs functions 5a/5l: add ARMv7 VFP ABS, SQRT and NEG F/D instructions First attempt to use ARMv7 FPU to speed up math package. test/bench/nbody is 7x faster.

Patch Set 1 #

Patch Set 2 : diff -r 96d9616ffbad https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 88bcc11652b9 https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -6 lines)			Patch
M	src/cmd/5a/lex.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/5l/5.out.h	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/cmd/5l/asm.c	View	1 2	2 chunks	+16 lines, -2 lines	0 comments	Download
M	src/cmd/5l/optab.c	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/cmd/5l/span.c	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/math/Makefile	View	1 2	3 chunks	+6 lines, -2 lines	0 comments	Download
A	src/pkg/math/fabs_arm.s	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	src/pkg/math/sqrt_arm.s	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fango

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2011-06-03 01:32:09 UTC) #1

rsc

12 years, 11 months ago (2011-06-03 01:39:53 UTC) #2

I don't understand why this is a new CL.
You had an existing CL:
http://codereview.appspot.com/4551082/

To add files to that CL you could have run
hg change 4551082
and then added them to the file list.

Let's settle on one CL number so that the
mail log is in one place.

I don't think absolute value is worth the effort
of writing an assembly function.  Let's just
work on getting square root working.  It still
needs the runtime help I described in my
comments on the other CL.

Russ

Expand All Messages | Collapse All Messages