Turn on -Wall in common.gypi, and clean up all warnings

The plain Makefile was using -Wall, but the gyp build wasn't.  This CL turns on -Wall -Wextra and -Wno-unused in common.gypi.  This revealed a lot of warnings (and some actual bugs), all of which I fixed here.  This is pretty mindless stuff for the most part (order of intialization, missing initializers, && within ||, etc), but will allow us to build cleanly with -Wall and -Wextra (and -Werror, if we so choose).

I put defaults into switches that were missing cases.  I could put in the actual missing enums instead if that's desired.  I could also assert on missing enums instead of break, if that's desired.  I wasn't sure how to test the stuff in "animator", so that should be looked at a bit more closely.

[Stephen White, 2011-05-19 19:00:43]

Remove some extra .gyp changes

[bsalomon, 2011-05-19 19:18:52]

LGTM

On 2011/05/19 19:00:43, Stephen White wrote:
> Remove some extra .gyp changes

[Stephen White, 2011-05-20 14:02:50]

Landed as r1386, closing.

[reed1, 2011-05-20 21:38:19]

LGTM

http://codereview.appspot.com/4547055/diff/11003/gpu/src/GrTesselatedPathRend...
File gpu/src/GrTesselatedPathRenderer.cpp (left):

http://codereview.appspot.com/4547055/diff/11003/gpu/src/GrTesselatedPathRend...
gpu/src/GrTesselatedPathRenderer.cpp:134: bool colorWritesWereDisabled =
target->isColorWriteDisabled();
Is this removal also just for warnings?

http://codereview.appspot.com/4547055/diff/11003/src/animator/SkDisplayApply.cpp
File src/animator/SkDisplayApply.cpp (left):

http://codereview.appspot.com/4547055/diff/11003/src/animator/SkDisplayApply....
src/animator/SkDisplayApply.cpp:481: bool success =
target->getProperty(info->propertyIndex(), &scriptValue);
yikes, good catch.

[Stephen White, 2011-05-20 21:53:58]

http://codereview.appspot.com/4547055/diff/11003/gpu/src/GrTesselatedPathRend...
File gpu/src/GrTesselatedPathRenderer.cpp (left):

http://codereview.appspot.com/4547055/diff/11003/gpu/src/GrTesselatedPathRend...
gpu/src/GrTesselatedPathRenderer.cpp:134: bool colorWritesWereDisabled =
target->isColorWriteDisabled();
On 2011/05/20 21:38:19, reed1 wrote:
> Is this removal also just for warnings?

Cargo cult programming.  This code was copied in from GrDefaultPathRenderer, but
isn't needed anymore, which the warning tipped me off too.