Issue 4539093: code review 4539093: template: fix quote-handling with formatters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4539093: code review 4539093: template: fix quote-handling with formatters (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by niemeyer

Modified:
13 years, 11 months ago

Reviewers:
gustavo, r2

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

template: fix quote-handling with formatters Fixes issue #1896.

Patch Set 1 #

Patch Set 2 : code review 4539093: template: fix quote-handling with formatters #

Patch Set 3 : code review 4539093: template: fix quote-handling with formatters #

Patch Set 4 : diff -r d857654eedd8 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3bea39b8b250 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	src/pkg/template/template.go	View	1 2 3	1 chunk	+5 lines, -4 lines	0 comments	Download
	M	src/pkg/template/template_test.go	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-05-29 02:48:15 UTC) #1

niemeyer

*** Submitted as http://code.google.com/p/go/source/detail?r=0323ec93cca5 *** template: fix quote-handling with formatters Fixes issue #1896. R=golang-dev, dsymonds ...

13 years, 11 months ago (2011-05-29 03:23:40 UTC) #3

There is no such thing as whitespace. Sometimes spaces are green. s/whitespace/space/ I'll give this ...

13 years, 11 months ago (2011-05-29 03:41:10 UTC) #4

gustavo_niemeyer.net

> There is no such thing as whitespace. Sometimes spaces are green. > s/whitespace/space/ Just ...

13 years, 11 months ago (2011-05-29 03:49:19 UTC) #5

13 years, 11 months ago (2011-05-29 04:30:53 UTC) #6

On 29/05/2011, at 1:48 PM, Gustavo Niemeyer wrote:

>> There is no such thing as whitespace. Sometimes spaces are green.
>> s/whitespace/space/
> 
> Just in terms of procedure, how does that usually work once it is
> already submitted?  Should I wait to put this as part of another more
> meaningful change to avoid bit-sized reviews, or is there another way
> to commit trivial/review-request changes?

There's no other way.  I used the opportunity to do a little more housekeeping.

-rob

Expand All Messages | Collapse All Messages