code review 4538092: go spec: be precise with the use of the informal ellips...

go spec: be precise with the use of the informal ellipsis  … and the Go token ...

Fixes issue 1867.

[gri, 2011-05-24 21:02:49]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-05-24 21:06:06]

http://codereview.appspot.com/4538092/diff/4004/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4538092/diff/4004/doc/go_spec.html#newcode78
doc/go_spec.html:78: enumerations or code snippets that are not further
specified; …
s/;/. The character

http://codereview.appspot.com/4538092/diff/4004/src/pkg/ebnf/parser.go
File src/pkg/ebnf/parser.go (right):

http://codereview.appspot.com/4538092/diff/4004/src/pkg/ebnf/parser.go#newcode98
src/pkg/ebnf/parser.go:98: if p.tok == token.ILLEGAL && p.lit == "…" {
it's pretty obscure what's going on. i think it would help to define a constant.

const ellipsis "…" // U+2026, the ellipsis character.

[gri, 2011-05-24 21:12:32]

PTAL

http://codereview.appspot.com/4538092/diff/4004/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4538092/diff/4004/doc/go_spec.html#newcode78
doc/go_spec.html:78: enumerations or code snippets that are not further
specified; …
On 2011/05/24 21:06:06, r wrote:
> s/;/. The character 

Done.

http://codereview.appspot.com/4538092/diff/4004/src/pkg/ebnf/parser.go
File src/pkg/ebnf/parser.go (right):

http://codereview.appspot.com/4538092/diff/4004/src/pkg/ebnf/parser.go#newcode98
src/pkg/ebnf/parser.go:98: if p.tok == token.ILLEGAL && p.lit == "…" {
On 2011/05/24 21:06:06, r wrote:
> it's pretty obscure what's going on. i think it would help to define a
constant.
> 
> const ellipsis "…" // U+2026, the ellipsis character.

Done.

[r, 2011-05-24 21:15:14]

LGTM

http://codereview.appspot.com/4538092/diff/5002/doc/go_spec.html
File doc/go_spec.html (right):

http://codereview.appspot.com/4538092/diff/5002/doc/go_spec.html#newcode79
doc/go_spec.html:79: (as opposed to <code>...</code>) is not a token of the Go
language.
maybe
as opposed to the three characters

[gri, 2011-05-24 21:18:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=681ae5d35602 ***

go spec: be precise with the use of the informal ellipsis  … and the Go token
...

Fixes issue 1867.

R=r
CC=golang-dev
http://codereview.appspot.com/4538092