Issue 4538073: code review 4538073: gif: fix setting of transparency channels when writing gifs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4538073: code review 4538073: gif: fix setting of transparency channels when writing gifs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by r

Modified:
13 years, 7 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

gif: fix setting of transparency channels when writing gifs.

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/cmd/jpg/gif.c	View		5 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Hello rsc@golang.org, I'd like you to review this change to http://code.swtch.com/plan9port

13 years, 8 months ago (2011-05-17 21:43:46 UTC) #1

rsc

13 years, 8 months ago (2011-05-17 21:46:50 UTC) #2

*** Submitted as fae0c6c8664c ***

gif: fix setting of transparency channels when writing gifs.

R=rsc
http://codereview.appspot.com/4538073

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages