Issue 4536065: code review 4536065: big: handle %v format again, and better handling of unk...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4536065: code review 4536065: big: handle %v format again, and better handling of unk... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by gri

Modified:
14 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

big: support %v and # modifier, better handling of unknown formats

Patch Set 1 #

Patch Set 2 : diff -r d74b7d671a0a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d74b7d671a0a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d74b7d671a0a https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 69b1a880814c https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r bf7512d859d5 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -10 lines)			Patch
M	src/pkg/big/int.go	View	1 2 3 4	3 chunks	+32 lines, -8 lines	0 comments	Download
M	src/pkg/big/int_test.go	View	1 2 3 4	13 chunks	+61 lines, -0 lines	0 comments	Download
M	src/pkg/big/nat.go	View	1 2 3 4	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-18 00:25:50 UTC) #1

gri

PTAL. While at it, I also fixed the handling on #, and correctly print nil ...

14 years ago (2011-05-18 17:59:43 UTC) #3

gri

14 years ago (2011-05-18 18:02:10 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=7af5ea683bc9 ***

big: support %v and # modifier, better handling of unknown formats

R=r
CC=golang-dev
http://codereview.appspot.com/4536065

Expand All Messages | Collapse All Messages