Issue 4535120: code review 4535120: net: fix bug in net.Interfaces: handle elastic sdl_data...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4535120: code review 4535120: net: fix bug in net.Interfaces: handle elastic sdl_data... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by mikio

Modified:
13 years, 11 months ago

Reviewers:

CC:
golang-dev, jmhodges

Visibility:
Public.

Description

net: fix bug in net.Interfaces: handle elastic sdl_data size correctly Fixes issue 1921.

Patch Set 1 #

Patch Set 2 : diff -r 65e1a4cd6869 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 65e1a4cd6869 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7164c59c6857 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/pkg/net/interface_bsd.go	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-06-06 12:44:55 UTC) #1

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 11 months ago (2011-06-06 15:38:15 UTC) #2

jmhodges

On 2011/06/06 15:38:15, mikioh wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > Please take another ...

13 years, 11 months ago (2011-06-06 17:39:12 UTC) #3

jmhodges

On 2011/06/06 17:39:12, jmhodges wrote: > On 2011/06/06 15:38:15, mikioh wrote: > > Hello mailto:golang-dev@googlegroups.com ...

13 years, 11 months ago (2011-06-06 17:57:14 UTC) #4

jmhodges

On 2011/06/06 17:57:14, jmhodges wrote: > On 2011/06/06 17:39:12, jmhodges wrote: > > On 2011/06/06 ...

13 years, 11 months ago (2011-06-07 16:23:46 UTC) #5

rsc

13 years, 11 months ago (2011-06-07 20:06:39 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=ee56a61d6f72 ***

net: fix bug in net.Interfaces: handle elastic sdl_data size correctly

Fixes issue 1921.

R=golang-dev, jeff
CC=golang-dev
http://codereview.appspot.com/4535120

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages