Issue 4535078: code review 4535078: syscall: add netlink support for linux/386, linux/amd64...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4535078: code review 4535078: syscall: add netlink support for linux/386, linux/amd64... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by mikio

Modified:
13 years, 12 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

syscall: add netlink support for linux/386, linux/amd64, linux/arm

Patch Set 2 : diff -r c5e4a635fbf1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c5e4a635fbf1 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1142 lines, -187 lines)			Patch
M	src/pkg/syscall/mkerrors.sh	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View	1	2 chunks	+26 lines, -1 line	0 comments	Download
M	src/pkg/syscall/types_linux.c	View	1	5 chunks	+57 lines, -1 line	0 comments	Download
M	src/pkg/syscall/zerrors_linux_386.go	View	1	3 chunks	+126 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_linux_amd64.go	View	1	3 chunks	+126 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zerrors_linux_arm.go	View	1	14 chunks	+423 lines, -113 lines	0 comments	Download
M	src/pkg/syscall/ztypes_linux_386.go	View	1	3 chunks	+102 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_linux_amd64.go	View	1	3 chunks	+102 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_linux_arm.go	View	1	6 chunks	+171 lines, -69 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 12 months ago (2011-05-17 18:14:06 UTC) #1

bradfitz

LGTM Leaving for others to review, though. http://codereview.appspot.com/4535078/diff/6002/src/pkg/syscall/ztypes_linux_arm.go File src/pkg/syscall/ztypes_linux_arm.go (right): http://codereview.appspot.com/4535078/diff/6002/src/pkg/syscall/ztypes_linux_arm.go#newcode113 src/pkg/syscall/ztypes_linux_arm.go:113: Pad_godefs_0 int32 ...

13 years, 12 months ago (2011-05-17 18:22:13 UTC) #2

bradfitz

Re-checked & built on linux/amd64 and linux/386. On Tue, May 17, 2011 at 11:22 AM, ...

13 years, 12 months ago (2011-05-18 23:33:43 UTC) #3

bradfitz

13 years, 12 months ago (2011-05-18 23:33:48 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=561f05b45049 ***

syscall: add netlink support for linux/386, linux/amd64, linux/arm

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4535078

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages