Issue 4535074: code review 4535074: 5c, 5g: another attempt at silencing gcc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4535074: code review 4535074: 5c, 5g: another attempt at silencing gcc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 11 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

5c, 5g: another attempt at silencing gcc

Patch Set 1 #

Patch Set 2 : diff -r 81a58517b871 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 81a58517b871 https://go.googlecode.com/hg #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
M	src/cmd/5c/gc.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/5c/peep.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/5g/gg.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/5g/peep.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 11 months ago (2011-05-16 20:15:12 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=d826fb286014 *** 5c, 5g: another attempt at silencing gcc R=ken2 CC=golang-dev http://codereview.appspot.com/4535074

13 years, 11 months ago (2011-05-16 20:15:20 UTC) #2

lgtm

Expand All Messages | Collapse All Messages