Issue 4532103: code review 4532103: runtime: do not garbage collect windows callbacks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4532103: code review 4532103: runtime: do not garbage collect windows callbacks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by brainman

Modified:
13 years, 11 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: do not garbage collect windows callbacks Fixes issue 1883. Fixes issue 1702.

Patch Set 1 #

Patch Set 2 : diff -r 798775ed7ee3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 798775ed7ee3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b7ac8e05d187 https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -3 lines)			Patch
	M	src/pkg/runtime/windows/thread.c	View	1 2 3	3 chunks	+37 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-06-01 05:39:10 UTC) #1

rsc

LGTM You can embed the Lock in the callback struct (just say Lock; instead of ...

13 years, 11 months ago (2011-06-01 14:03:57 UTC) #2

brainman

13 years, 11 months ago (2011-06-02 07:09:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=95553202a7a8 ***

runtime: do not garbage collect windows callbacks

Fixes issue 1883.
Fixes issue 1702.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4532103

Expand All Messages | Collapse All Messages