Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3650)

Issue 4532102: [pph] Renaming output/write and input/read to out/in + standardizing pph_stream_* to pph_* (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Gabriel Charette
Modified:
12 years, 10 months ago
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn://gcc.gnu.org/svn/gcc/branches/pph/gcc/cp/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+540 lines, -540 lines) Patch
M name-lookup.c View 1 chunk +13 lines, -13 lines 0 comments Download
M pph.c View 30 chunks +69 lines, -69 lines 0 comments Download
M pph-streamer.h View 12 chunks +75 lines, -75 lines 0 comments Download
M pph-streamer.c View 12 chunks +30 lines, -30 lines 0 comments Download
M pph-streamer-in.c View 41 chunks +174 lines, -174 lines 1 comment Download
M pph-streamer-out.c View 51 chunks +179 lines, -179 lines 0 comments Download

Messages

Total messages: 3
Gabriel Charette
2011-05-31 Gabriel Charette <gchare@google.com> * pph-streamer-in.c (pph_unpack_value_fields): Rename from pph_stream_unpack_value_fields. Update all users. (pph_init_read): Rename ...
12 years, 11 months ago (2011-06-01 02:50:19 UTC) #1
Diego Novillo
Looks OK. One minor formatting comment that I will fix myself when I commit the ...
12 years, 11 months ago (2011-06-01 13:06:15 UTC) #2
Diego Novillo
12 years, 11 months ago (2011-06-01 14:46:46 UTC) #3
On 2011/06/01 13:06:15, Diego Novillo wrote:
> Looks OK.  One minor formatting comment that I will fix myself when I commit
the
> patch.

Committed as rev 174530.


Diego.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b