Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(698)

Issue 4532069: code review 4532069: 6l: fix emit windows dwarf sections (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by vcc
Modified:
14 years ago
Reviewers:
CC:
brainman, rsc, golang-dev, vcc
Visibility:
Public.

Description

6l: fix emit windows dwarf sections

Patch Set 1 #

Patch Set 2 : code review 4532069: 6l: fix emit windows dwarf sections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/cmd/6l/asm.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
vcc
Hello brainman, rsc (cc: golang-dev@googlegroups.com, vcc), I'd like you to review this change.
14 years ago (2011-05-18 09:04:15 UTC) #1
vcc
Thanks Alex, I can use gdb x64 debug now. 2011/5/18 <vcc.163@gmail.com>: > Reviewers: brainman, rsc, ...
14 years ago (2011-05-18 09:12:49 UTC) #2
brainman
LGTM. My mistake.
14 years ago (2011-05-18 11:33:20 UTC) #3
rsc
LGTM
14 years ago (2011-05-18 17:12:28 UTC) #4
rsc
14 years ago (2011-05-18 17:12:41 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=b8e5a9a19c72 ***

6l: fix emit windows dwarf sections

R=alex.brainman, rsc
CC=golang-dev, vcc.163
http://codereview.appspot.com/4532069

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b