Issue 4530112: Makes outside-staff-property work for TupletNumber.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4530112: Makes outside-staff-property work for TupletNumber. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by MikeSol

Modified:
12 years, 10 months ago

Reviewers:
mike, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Makes outside-staff-property work for TupletNumber.

Patch Set 1 #

Total comments: 2

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	scm/define-grobs.scm	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	scm/output-lib.scm	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSol

>Making 'outside-staff-priority work properly for tuplets >would be a useful addition. Probably easier than adding ...

12 years, 10 months ago (2011-06-06 19:06:18 UTC) #1

Neil Puttock

LGTM. http://codereview.appspot.com/4530112/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4530112/diff/1/scm/define-grobs.scm#newcode2344 scm/define-grobs.scm:2344: (direction . ,tuplet-number::calc-direction) add `direction' to tuplet-number.cc for ...

12 years, 10 months ago (2011-06-12 16:52:44 UTC) #2

mike_apollinemike.com

12 years, 10 months ago (2011-06-13 11:34:59 UTC) #3

On Jun 12, 2011, at 6:52 PM, n.puttock@gmail.com wrote:

> LGTM.
> 
> 
> http://codereview.appspot.com/4530112/diff/1/scm/define-grobs.scm
> File scm/define-grobs.scm (right):
> 
> http://codereview.appspot.com/4530112/diff/1/scm/define-grobs.scm#newcode2344
> scm/define-grobs.scm:2344: (direction  . ,tuplet-number::calc-direction)
> add `direction' to tuplet-number.cc for documentation
> 
> http://codereview.appspot.com/4530112/diff/1/scm/output-lib.scm
> File scm/output-lib.scm (right):
> 
> http://codereview.appspot.com/4530112/diff/1/scm/output-lib.scm#newcode330
> scm/output-lib.scm:330: (define-public (tuplet-number::calc-direction
> grob)
> move above `tuplet-number::cacl-denominator-text'


Done.  Passed regtests, so added a regtest & pushed.

b375521f6040ee5e894e80755e89f2b36795eb1a

Cheers,
MS

Expand All Messages | Collapse All Messages