Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 4530095: [pph] Stream lang_decl_min in lang_decl_fn (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by Lawrence Crowl
Modified:
12 years, 10 months ago
Reviewers:
Diego Novillo
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/pph/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gcc/cp/pph-streamer-in.c View 1 chunk +3 lines, -0 lines 0 comments Download
M gcc/cp/pph-streamer-out.c View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Lawrence Crowl
13 years, 10 months ago (2011-06-02 01:02:55 UTC) #1
The struct lang_decl_fn contains a struct lang_decl_min as a field,
but we were not streaming it.  This patch streams that field.  This
patch doesn't make any new testcases work, but it makes them fail
later.

Tested on x86-64.  Committed.


Index: gcc/cp/ChangeLog.pph

2011-06-01  Lawrence Crowl <crowl@google.com>

	* pph-streamer-in.c (pph_in_ld_fn): Stream in struct
	lang_decl_min because it is a member of struct lang_decl_fn.
	* pph-streamer-out.c (pph_in_ld_fn): Stream out struct
	lang_decl_min because it is a member of struct lang_decl_fn.


Index: gcc/cp/pph-streamer-in.c
===================================================================
--- gcc/cp/pph-streamer-in.c	(revision 174550)
+++ gcc/cp/pph-streamer-in.c	(working copy)
@@ -562,6 +562,9 @@ pph_in_ld_fn (pph_stream *stream, struct
 {
   struct bitpack_d bp;
 
+  /* Read all the fields in lang_decl_min.  */
+  pph_in_ld_min (stream, &ldf->min);
+
   bp = pph_in_bitpack (stream);
   ldf->operator_code = (enum tree_code) bp_unpack_value (&bp, 16);
   ldf->global_ctor_p = bp_unpack_value (&bp, 1);
Index: gcc/cp/pph-streamer-out.c
===================================================================
--- gcc/cp/pph-streamer-out.c	(revision 174550)
+++ gcc/cp/pph-streamer-out.c	(working copy)
@@ -550,6 +550,9 @@ pph_out_ld_fn (pph_stream *stream, struc
 {
   struct bitpack_d bp;
 
+  /* Write all the fields in lang_decl_min.  */
+  pph_out_ld_min (stream, &ldf->min, ref_p);
+
   bp = bitpack_create (stream->ob->main_stream);
   bp_pack_value (&bp, ldf->operator_code, 16);
   bp_pack_value (&bp, ldf->global_ctor_p, 1);

--
This patch is available for review at http://codereview.appspot.com/4530095
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b